feat(supervisor): make run pod automountServiceAccountToken configurable - #4302
Conversation
|
|
Hi @danhngo-lx, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughAdds two supervisor environment variables for Kubernetes worker pods: one controlling ServiceAccount token automounting, disabled by default, and one selecting an optional ServiceAccount name. Pod generation now applies these settings. Documentation and a server-change note describe the configuration. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
1 participant
✅ Checklist
Testing
KUBERNETES_WORKER_AUTOMOUNT_SERVICE_ACCOUNT_TOKENto trueChangelog
Run (worker) pods hardcoded automountServiceAccountToken: false, so no in-cluster ServiceAccount token/CA was mounted and workload code talking to the Kubernetes API failed (e.g. @kubernetes/client-node falling back to http://localhost:8080 -> ECONNREFUSED).
Add KUBERNETES_WORKER_AUTOMOUNT_SERVICE_ACCOUNT_TOKEN (bool, default false) to control the pod spec field, plus KUBERNETES_WORKER_SERVICE_ACCOUNT_NAME to optionally run pods under a specific ServiceAccount. Both default to today's behavior, so this is non-breaking.
Screenshots
(No screenshots)
💯